Fixed dashboard wrapper codesandbox export error#7954
Merged
tlabaj merged 1 commit intopatternfly:mainfrom Sep 9, 2022
Merged
Conversation
Collaborator
|
Preview: https://patternfly-react-pr-7954.surge.sh A11y report: https://patternfly-react-pr-7954-a11y.surge.sh |
gitdallas
approved these changes
Sep 9, 2022
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
andyyvo
pushed a commit
to andyyvo/patternfly-react
that referenced
this pull request
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #6596
This PR changes all imports of
DashboardWrapperandDashboardHeaderfrom relative imports paths to absolute import paths, which allows Codesandbox to properly load the components.Note: DashboardHeader image is not loading correctly in Codesandbox and will require separate investigation:
Note: a different solution was implemented for relative import paths for patternfly.org, but that did not translate to the problem here as that relies on the files being imported from an external package. Updating the relative paths here will not conflict with that update as it will bypass the check for a relative import path implemented in that issue.